[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/3] xen: arm: probe the kernel to determine the guest type earlier
Hi Ian, On 04/04/2014 01:56 PM, Ian Campbell wrote: > +static paddr_t kernel_zimage_place(struct kernel_info *info) > +{ > + paddr_t load_addr; > + > +#ifdef CONFIG_ARM_64 > + if ( info->type == DOMAIN_64BIT ) > + return info->mem.bank[0].start + info->zimage.text_offset; > +#endif > + > + /* > + * If start is zero, the zImage is position independent, in this > + * case Documentation/arm/Booting recommends loading below 128MiB > + * and above 32MiB. Load it as high as possible within these > + * constraints, while also avoiding the DTB. > + */ > + if (info->zimage.start == 0) if ( ... ) [..] > -int kernel_prepare(struct kernel_info *info); > +/* > + * Probe the kernel to detemine its type and select a loader. > + * > + * Sets in info: > + * ->type > + * ->load hook, and sets loader specific variables ->{zimage,elf} > + */ > +int kernel_probe(struct kernel_info *info); I would add a newline here. With theses 2 minor changes, the code looks good to me: Acked-by: Julien Grall <julien.grall@xxxxxxxxxx> Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |