Re: [Xen-devel] [PATCH v2 08/15] xen/arm: use device api to detect GIC version

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijaya,

Thank you for the patch.

On 04/04/2014 12:56 PM, vijay.kilari@xxxxxxxxx wrote:
> @@ -253,8 +254,22 @@ int gic_irq_xlate(const u32 *intspec, unsigned int 
> intsize,
>  /* Set up the GIC */
>  void __init gic_init(void)
>  {
> -    gicv2_init();
> +    int rc;
> +    struct dt_device_node *node;
> +    unsigned int num_gics = 0;
> +
>      spin_lock_init(&gic_lock);
> +    spin_lock(&gic_lock);

Why do you take the lock here?

> +
> +    dt_for_each_device_node(dt_host, node)
> +    {
> +        rc = device_init(node, DEVICE_GIC, NULL);
> +        if ( !rc )
> +            num_gics++;

Xen only supports a single GIC for now. You have to initialized the
correct one (see dt_find_interrupt_controller).

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel