Re: [Xen-devel] [PATCH 09/34] xen/common: tmem: Remove dumb check in do_tmem_destroy_pool

[Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>]

On Tue, Mar 25, 2014 at 06:18:21PM +0000, Julien Grall wrote:
> Hi Andrew,
> 
> I just saw that a patch was already sent few months ago
> (http://lists.xenproject.org/archives/html/xen-devel/2013-11/msg03664.html),
> but never upstreamed.
> 
> Konrad, I'm fine to drop this patch if you plan to send your series.

Nah, lets use this patch. Thanks!

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

> 
> Regards,
> 
> On 03/25/2014 06:05 PM, Andrew Cooper wrote:
> > On 25/03/14 16:55, Julien Grall wrote:
> >> do_tmem_destroy_pool is checking if pools == NULL. But, pools is a fixed
> >> array.
> >>
> >> Clang 3.5 will fail to compile xen/common/tmem.c with the following error:
> >> tmem.c:1848:18: error: comparison of array 'client->pools' equal to a null 
> >> pointer is always false [-Werror,-Wtautological-pointer-compare]
> >>     if ( client->pools == NULL )
> > 
> > Coverity-ID:1055632
> > 
> > ~Andrew
> > 
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> >> ---
> >>  xen/common/tmem.c |    2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/xen/common/tmem.c b/xen/common/tmem.c
> >> index 02e7e2e..0a24b3f 100644
> >> --- a/xen/common/tmem.c
> >> +++ b/xen/common/tmem.c
> >> @@ -1845,8 +1845,6 @@ static int do_tmem_destroy_pool(uint32_t pool_id)
> >>      struct client *client = current->domain->tmem_client;
> >>      struct tmem_pool *pool;
> >>  
> >> -    if ( client->pools == NULL )
> >> -        return 0;
> >>      if ( pool_id >= MAX_POOLS_PER_DOMAIN )
> >>          return 0;
> >>      if ( (pool = client->pools[pool_id]) == NULL )
> > 
> 
> 
> -- 
> Julien Grall
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel