Re: [Xen-devel] [RFC] tools/libxl: add disk snapshot support

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Bamvor Jian Zhang writes ("[RFC] tools/libxl: add disk snapshot support"):
> add internal disk snapshot support through qemu qmp, including create,
> delete and list.

Thanks for this submission.

To review this idea, I think it is really necessary for me to
understand the proposed semantics.  Sadly you don't provide a
documentation patch.

I think this would be much easier to review in the form of a patch to
docs/man/xl.pod.1.  There needs to be a conceptual explanation of what
a snapshot is, where it is stored, and so forth.

Your code appears simply to send some messages to qemu.  I don't
understand how that can do anything particularly useful.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel