Re: [Xen-devel] [PATCH 05/10 V7] remus: Remus network buffering core and APIs to setup/teardown [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yang Hongyang writes ("[PATCH V8 3/8] remus: Remus network buffering core and 
APIs to setup/teardown"):
> 1.Add two members in libxl_domain_remus_info:
>     netbuf: whether netbuf is enabled
>     netbufscript: the path of the script which will be run to setup
>        and tear down the guest's interface.
> 2.introduce a new structure libxl__remus_state to save the remus state
> 3.introduces remus-netbuf-setup hotplug script responsible for
>   setting up and tearing down the necessary infrastructure required for
>   network output buffering in Remus.  This script is intended to be invoked
>   by libxl for each guest interface, when starting or stopping Remus.

Thanks for your submission.

However, the last time this was posted, I commented as follows:

  > This function [netbuf_setup_timeout_cb] bears a striking
  > resemblance to device_hotplug_timeout_cb.  Likewise parts of
  > exec_netbuf_script look very much like parts of device_hotplug,
  > etc.
  > 
  > You should arrange to reuse code rather than clone-and-hacking it,
  > refactoring if necessary.  If refactoring is necessary, that should be
  > brought out into a pre-patch with no functional change.

It looks like several of my other comments haven't been taken into
account, either.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel