Re: [Xen-devel] [PATCH V4 08/12] TestSupport.pm: introduce copy_iso_content_to_dir

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 02, 2014 at 05:10:52PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH V4 08/12] TestSupport.pm: introduce 
> copy_iso_content_to_dir"):
> > ... which returns a string of commands to pass into target_cmd_root.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Although I'm starting to wonder about the names here:
> 
> >                        create_iso_xorriso
> >                        create_empty_iso
> >                        iso_gen_flags_basic
> > +                      copy_iso_content_to_dir
> >                        rewrite_config_nocd
> 
> Maybe some of these should be called   iso_create_xorriso
> iso_create_empty  etc.
> 
> And maybe this one
> 
> > +sub copy_iso_content_to_dir($$) {
> > +    my ($gho,$newiso) = @_;
> > +    return <<"END";
> > +            set -ex
> > +            umount /mnt ||:
> > +            rm -rf $newiso
> > +            mount -o loop -r $gho->{Rimage} /mnt
> 
> should mention the word "image" in its name.  Eg
> "iso_copy_content_from_image" or something.
> 
> Let me know what you think.
> 

I'm fine with those renames. Will update in my next series.

Wei.

> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel