Re: [Xen-devel] [PATCH v8 20/20] xenctx: Ensure errno is not zero on error in xc_translate_foreign_address()

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 04/01/14 10:30, Ian Campbell wrote:
> On Thu, 2014-03-27 at 15:05 -0400, Don Slutz wrote:
> > This is because xc_translate_foreign_address() returns 0 in both the
> > error case and when 0 is the mfn.  By making sure that errno is set
> > callers can now determine if it is an error or not.
> I think it would be preferable to change the function to return the
> translated address via an output pointer and make the formal return be
> an int 0 (success) or -1 (error, sets errno).
>
> That would be both more normal and remove all the frobbing around with
> errno.
>
> Ian.
I was not of mind to change an existing interface.  Will drop this from this 
patch set.

   -Don Slutz


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel