[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 12/20] xenctx: Add -d (--dump-as-stack) <daddr> option to dump memory at daddr as a stack.



On Thu, 2014-03-27 at 15:05 -0400, Don Slutz wrote:
> Also switch from read_stack_word to read_mem_word since the provided
> address may not be aligned.
> 
> Signed-off-by: Don Slutz <Don@xxxxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
{

But:

> @@ -1057,7 +1069,7 @@ int main(int argc, char **argv)
>              {
>                  fprintf(stderr,
>                          "%s: Unsupported value(%d) for --display-stack-pages 
> '%s'. Needs to be >= 1\n",
> -                        argv[0], xenctx.nr_stack_pages, optarg);
> +                        prog, xenctx.nr_stack_pages, optarg);

Stray hunk from a previous patch?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.