[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] libxl: Set guest parameters from config file during a restore
On 04/01/2014 06:37 AM, Ian Campbell wrote: On Sat, 2014-03-29 at 23:05 -0400, Boris Ostrovsky wrote:@@ -484,22 +506,11 @@ static int hvm_build_set_params(xc_interface *handle, uint32_t domid,xc_get_hvm_param(handle, domid, HVM_PARAM_STORE_PFN, store_mfn);xc_get_hvm_param(handle, domid, HVM_PARAM_CONSOLE_PFN, console_mfn); - xc_set_hvm_param(handle, domid, HVM_PARAM_PAE_ENABLED, - libxl_defbool_val(info->u.hvm.pae)); -#if defined(__i386__) || defined(__x86_64__) - xc_set_hvm_param(handle, domid, HVM_PARAM_VIRIDIAN, - libxl_defbool_val(info->u.hvm.viridian)); - xc_set_hvm_param(handle, domid, HVM_PARAM_HPET_ENABLED, - libxl_defbool_val(info->u.hvm.hpet)); -#endif - xc_set_hvm_param(handle, domid, HVM_PARAM_TIMER_MODE, timer_mode(info)); - xc_set_hvm_param(handle, domid, HVM_PARAM_VPT_ALIGN, - libxl_defbool_val(info->u.hvm.vpt_align)); - xc_set_hvm_param(handle, domid, HVM_PARAM_NESTEDHVM, - libxl_defbool_val(info->u.hvm.nested_hvm)); xc_set_hvm_param(handle, domid, HVM_PARAM_STORE_EVTCHN, store_evtchn); xc_set_hvm_param(handle, domid, HVM_PARAM_CONSOLE_EVTCHN, console_evtchn);+ hvm_set_conf_params(handle, domid, info);Can you confirm that this isn't now called twice on domain create, once from libxl__build_pre and then again here. No, I can't.I thought I checked that libxl__build_pre() is not called on create and of course it clearly is. So this was me being rather sloppy. I'll remove hvm_set_conf_params() call from hvm_build_set_params() and leave it only in libxl__build_pre(). -boris _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |