Re: [Xen-devel] [PATCH] xen: arm: fully implement multicall interface.

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/28/2014 03:03 PM, Jan Beulich wrote:
> > > > On 28.03.14 at 15:37, <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Fri, 2014-03-28 at 14:22 +0000, Julien Grall wrote:
> > > On 03/28/2014 02:07 PM, Ian Campbell wrote:
> > > > I'm not sure what I was smoking at the time of 5d74ad1a082e "xen: arm:
> > > > implement do_multicall_call for both 32 and 64-bit" but it is obviously
> > > > insufficient since it doesn't actually wire up the hypercall.
> > > >
> > > > Before doing so we need to make the usual adjustments for ARM and turn the
> > > > unsigned longs into xen_ulong_t. There is no difference in the resulting
> > > > structure for x86.
> > > >
> > > > There are knock on changes to the trace interface, but again they are nops
> > on
> > > > x86.
> > > I'm wondering if you also need to modify __trace_multicall_call in
> > > common/compat/multicall.c. (I know it's not used by ARM...).
> > I did build test x86_64, but perhaps I should make a change here anyway
> > for consistency. George/Jan?
> It doesn't matter that much, but for consistency's sake it would seem
> desirable.
+1

 -G

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel