Re: [Xen-devel] [PATCH v10 1/6] x86: detect and initialize Cache QoS Monitoring feature

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.03.14 at 17:33, <dongxiao.xu@xxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >>> On 26.03.14 at 07:35, <dongxiao.xu@xxxxxxxxx> wrote:
>> > +    /* According to Intel SDM, the possible maximum rmid number is 2^10 = 
>> > 1024,
>> > +     * thus one page is enough to hold cqm->rmid_to_dom structure */
>> > +    cqm->rmid_to_dom = alloc_xenheap_page();
>> 
>> But please validate that this condition is being met (not necessarily here,
>> perhaps rather where rmid_max gets determined).
> 
> Okay, will add one ASSERT() to validate this condition.

And btw, please fix your multi-line comment style.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel