Re: [Xen-devel] [PATCH v2 00/17] xen: arm: resync low level asm primitive from Linux

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-27 at 17:59 +0100, Tim Deegan wrote:
> At 13:36 +0000 on 26 Mar (1395837409), Ian Campbell wrote:
> > (Jan/Keir -- only the first patch is of interest to you, Jan has
> > reviewed it but an Ack from you Keir would be useful)
> > 
> > The following resyncs the bitops, atomics, cmpxchg and various optimised
> > library functions (str*, mem*, clear_page) from Linux. It also adds
> > various additional optimised variants, especially for arm64 which was
> > lacking them in Linux when we started.
> 
> Acked-by: Tim Deegan <tim@xxxxxxx>

Thanks.

> On ething that occurred to me, reading so soon after Julien's clang
> series, is that we might just export mem{copy,move,set} symbols
> directly as both their plain names and __aeabi_ versions, to save
> having an eabi.c that just wraps them.

You mean in xen/arch/arm/arm32/lib/memcpy.S:

ENTRY(memcpy)
ENTRY(__aeabi_memcpy)
        /* body */
ENDPROC(???)

Or something? That does seem quite sensible actually.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel