Re: [Xen-devel] [PATCH v5 12/17] xenctx: change is_kernel_text() into kernel_addr().

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 03/21/14 13:45, Don Slutz wrote:
> On 03/21/14 11:02, Ian Campbell wrote:
> > On Thu, 2014-03-20 at 15:07 -0400, Don Slutz wrote:
> > > A new enum has been added to allow the caller to determine if this
> > > kernel address is a text or data address.  This is currenlty not
> > > used, but will be in the next patch.
> > >
> > > Signed-off-by: Don Slutz <Don@xxxxxxxxxxxxxxx>
> > > ---
> > >   tools/xentrace/xenctx.c | 70 +++++++++++++++++++++++++++++++++++--------------
> > >   1 file changed, 51 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> > > index f77f17e..c574996 100644
> > > --- a/tools/xentrace/xenctx.c
> > > +++ b/tools/xentrace/xenctx.c
> > > @@ -33,6 +33,15 @@
> > >   #define DEFAULT_BYTES_PER_LINE 32
> > >   #define DEFAULT_LINES 5
> > >   +/* Note: the order of these matter.
> > > + * NOT_KERNEL_ADDR must be < both KERNEL_DATA_ADDR and KERNEL_TEXT_ADDR.
> > > + * KERNEL_DATA_ADDR must be < KERNEL_TEXT_ADDR. */
> > > +typedef enum type_of_addr_ {
> > > +    NOT_KERNEL_ADDR,
> > AKA a User Address?
> Yes.
>    -Don Slutz
I have now found out this is not correct. kernel module addresses are also 
NOT_KERNEL_ADDR.  Not sure what needs to be done here. Also turn out that:

ffffffffff600000 T vgettimeofday
ffffffffff60000f t vsysc2
ffffffffff600180 D __xtime_lock
ffffffffff600190 D __vxtime
ffffffffff6001c0 D __vgetcpu_mode
ffffffffff6001d0 D __wall_jiffies
ffffffffff6001e0 D __sys_tz
ffffffffff6001f0 D __sysctl_vsyscall
ffffffffff600200 D __xtime
ffffffffff600280 D __jiffies
ffffffffff600400 T vtime
ffffffffff60040e t vsysc1
ffffffffff600800 T vgetcpu
ffffffffff600c00 T venosys_1

will not be matched.  Not sure what is the right thing to do here.


   -Don Slutz




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel