Re: [Xen-devel] [PATCH v4 06/10] xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-03-21 at 16:20 +0000, Stefano Stabellini wrote:
> On Fri, 21 Mar 2014, Ian Campbell wrote:
> > On Wed, 2014-03-19 at 12:32 +0000, Stefano Stabellini wrote:
> > > Rename gic_set_guest_irq to gic_raise_guest_irq and remove the state
> > > parameter.
> > > 
> > > @@ -689,7 +689,7 @@ void gic_set_guest_irq(struct vcpu *v, unsigned int 
> > > irq,
> > >          i = find_first_zero_bit(&this_cpu(lr_mask), nr_lrs);
> > >          if (i < nr_lrs) {
> > >              set_bit(i, &this_cpu(lr_mask));
> > > -            gic_set_lr(i, irq_to_pending(v, irq), state);
> > > +            gic_set_lr(i, irq_to_pending(v, irq), GICH_LR_PENDING);
> > 
> > Is this a stray change which belopngs in another patch?
> 
> No, in the commit message I wrote:
> 
> "Rename gic_set_guest_irq to gic_raise_guest_irq and remove the state
> parameter."

Ah, I missed that this change was inside gic_set_guest_irq itself, sorry
for the noise.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel