Re: [Xen-devel] [PATCH v5 13/17] xenctx: Add convert of more registers to symbols

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-03-21 at 15:11 +0000, Jan Beulich wrote:
> >>> On 21.03.14 at 16:07, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Thu, 2014-03-20 at 15:07 -0400, Don Slutz wrote:
> > 
> >> @@ -368,8 +380,11 @@ static void print_ctx_32(vcpu_guest_context_x86_32_t 
> >> *ctx)
> >>      printf(" gs:     %04x\n", regs->gs);
> >>  
> >>      if (xenctx.disp_all) {
> >> -        print_special(ctx->ctrlreg, "cr", 0x1d, 4);
> >> -        print_special(ctx->debugreg, "dr", 0xcf, 4);
> >> +        uint64_t cr_reg_mask[5] = {0, 0, ~0ULL};
> >> +        uint64_t dr_reg_mask[8] = {~0ULL, ~0ULL, ~0ULL, ~0ULL};
> > 
> > Are you really using 8*64 bits to represent 8 boolean values? Your masks
> > are all 0 or ~0.
> 
> Actually I had asked for this, since special registers may happen to have
> (often at their bottom or top) bits not being part of an address.

I thought that might be the case, but I couldn't find any actual
printing of such a register.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel