Re: [Xen-devel] [PATCH v5 15/17] xenctx: Fix handling of !guest_protected_mode

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-20 at 15:07 -0400, Don Slutz wrote:
> @@ -851,6 +861,9 @@ static int print_stack(vcpu_guest_context_any_t *ctx, int 
> vcpu, int width, guest
>              return -1;
>      }
>  
> +    if ( !guest_protected_mode )
> +        return 0;
> +
>      if(xenctx.stack_trace)
>          printf("Stack Trace:\n");
>      else
> @@ -1016,7 +1029,8 @@ static void dump_ctx(int vcpu)
>  #ifndef NO_TRANSLATION
>      if (print_code(&ctx, vcpu))
>          return;
> -    if ( kernel_addr(instr_pointer(&ctx)) >= KERNEL_TEXT_ADDR )
> +    if ( !guest_protected_mode ||

Aren't this and the check in the previous hunk contradictory and/or
equivalent (I can't decide which)

> +         kernel_addr(instr_pointer(&ctx)) >= KERNEL_TEXT_ADDR )
>          if ( print_stack(&ctx, vcpu, guest_word_size,
>                           stack_pointer(&ctx)) )
>              return;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel