Re: [Xen-devel] [PATCH] minios (blkfront): Drop unused total_bytes field

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-20 at 12:45 +0100, Samuel Thibault wrote:
> The total_bytes field of blkfront_aiocb is never used.

Are you sure?:

/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c: In function 
âvbd_do_aioâ:
/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c:154:11: 
error: âstruct blkfront_aiocbâ has no member named âtotal_bytesâ
/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c:155:15: 
error: âstruct blkfront_aiocbâ has no member named âtotal_bytesâ
/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c:158:36: 
error: âstruct blkfront_aiocbâ has no member named âtotal_bytesâ
/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c:158:142: 
error: âstruct blkfront_aiocbâ has no member named âtotal_bytesâ
/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c: In function 
âvbd_aio_setupâ:
/local/scratch/ianc/devel/committer.git/stubdom/ioemu/block-vbd.c:232:15: 
error: âstruct blkfront_aiocbâ has no member named âtotal_bytesâ
make[3]: *** [block-vbd.o] Error 1
make[3]: *** Waiting for unfinished jobs....


> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> diff --git a/extras/mini-os/include/blkfront.h 
> b/extras/mini-os/include/blkfront.h
> index 3528af9..9bcf93f 100644
> --- a/extras/mini-os/include/blkfront.h
> +++ b/extras/mini-os/include/blkfront.h
> @@ -8,7 +8,6 @@ struct blkfront_aiocb
>      uint8_t *aio_buf;
>      size_t aio_nbytes;
>      off_t aio_offset;
> -    size_t total_bytes;
>      uint8_t is_write;
>      void *data;
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel