Re: [Xen-devel] [PATCH] xen/balloon: export balloon hotplug page stats to sysfs

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Mar 20, 2014 at 12:56:53PM +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Konrad Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: David Vrabel <david.vrabel@xxxxxxxxxx>
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
>  drivers/xen/xen-balloon.c |    9 +++++++++

If you are doing that you also need to put information in
Documentation/sysfs/abi/something/somewhere.

>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/xen/xen-balloon.c b/drivers/xen/xen-balloon.c
> index e555845..2d4c5a8 100644
> --- a/drivers/xen/xen-balloon.c
> +++ b/drivers/xen/xen-balloon.c
> @@ -129,6 +129,11 @@ module_exit(balloon_exit);
>  BALLOON_SHOW(current_kb, "%lu\n", PAGES2KB(balloon_stats.current_pages));
>  BALLOON_SHOW(low_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_low));
>  BALLOON_SHOW(high_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_high));
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> +BALLOON_SHOW(hotplug_kb, "%lu\n", PAGES2KB(balloon_stats.hotplug_pages));
> +BALLOON_SHOW(balloon_hotplug_kb, "%lu\n",
> +          PAGES2KB(balloon_stats.balloon_hotplug));
> +#endif
>  
>  static DEVICE_ULONG_ATTR(schedule_delay, 0444, balloon_stats.schedule_delay);
>  static DEVICE_ULONG_ATTR(max_schedule_delay, 0644, 
> balloon_stats.max_schedule_delay);
> @@ -206,6 +211,10 @@ static struct attribute *balloon_info_attrs[] = {
>       &dev_attr_current_kb.attr,
>       &dev_attr_low_kb.attr,
>       &dev_attr_high_kb.attr,
> +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> +     &dev_attr_hotplug_kb.attr,
> +     &dev_attr_balloon_hotplug_kb.attr,
> +#endif
>       NULL
>  };
>  
> -- 
> 1.7.10.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel