Re: [Xen-devel] [PATCH OSSTEST 2/2] standalone mode convenience frontend

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-20 at 16:31 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST 2/2] standalone mode convenience 
> frontend"):
> > I can never remember all the various env vars which I can/should set so this
> > tool provides a command line veneer over the basics.
> > 
> > It also does some sanity checks for things which keep tripping me up
> > (inability to read apache logs, lack of ssh-agent) which fail in more or 
> > less
> > obscure ways.
> 
> This seems useful.  I have only a couple of trivial style comments.
> 
> 
> > +        env DAILY_BRANCH_PREEXEC_HOOK=exit\ 0 \
> > +            OSSTEST_USE_HEAD=y \
> > +            BRANCHES_ALWAYS="$branch" \
> > +            OSSTEST_FLIGHT=$flight \
> > +            OSSTEST_CONFIG=$config \
> > +            OSSTEST_NO_BASELINE=y \
> > +                ./cr-daily-branch $@ $branch
> 
> The use of "env" here is unnecessary.

Yes, I wonder what was happening to cause me to think I needed it...

> ...
> > +           ./sg-run-job $job 2>&1 | tee logs/$flight/$job.log
> > +   rc=${PIPESTATUS[0]}
> > +   if [ $rc -ne 0 ] ; then
> > +       echo "FAILED rc=${rc}" >&2
> > +   fi
> 
> These 4.5 lines occur twice in this file.  Perhaps another subroutine
> to handle the logging ?

Sure. Unless the subroutine call is going to muck with ${PIPSTATUS[0]}
somehow -- I need to check that.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel