Re: [Xen-devel] [PATCH] serial: Expand the PCIe params for an Oxford two port serial cards.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.03.14 at 16:54, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> On Wed, Mar 19, 2014 at 03:29:31PM +0000, Jan Beulich wrote:
>> >>> On 19.03.14 at 16:18, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:
>> > @@ -161,12 +172,24 @@ static const struct ns16550_config_mmio __initconst 
> uart_config[] =
>> >      /* OXPCIe952 1 Native UART  */
>> >      {
>> >          .vendor_id = PCI_VENDOR_ID_OXSEMI,
>> > +        .dev_id = 0xc158,
>> > +        .param = param_oxford_2port,
>> > +    },
>> > +    /* OXPCIe952 1 Native UART  */
>> > +    {
>> > +        .vendor_id = PCI_VENDOR_ID_OXSEMI,
>> >          .dev_id = 0xc13d,
>> >          .param = param_oxford,
>> >      },
>> >      /* OXPCIe952 1 Native UART  */
>> >      {
>> >          .vendor_id = PCI_VENDOR_ID_OXSEMI,
>> > +        .dev_id = 0xc15d,
>> > +        .param = param_oxford_2port,
>> > +    },
>> > +    /* OXPCIe952 1 Native UART  */
>> > +    {
>> > +        .vendor_id = PCI_VENDOR_ID_OXSEMI,
>> >          .dev_id = 0xc40b,
>> >          .param = param_oxford,
>> >      },
>> 
>> While at first I only wanted to ask by what principle these entries
>> are being ordered, I now additionally wonder what really
> 
> I was putting them in the order of device_id. But I can also
> put them at the end of the structure if you would prefer?

No, that's fine. And you saying that made me realize that I too
the bottom most number visible above as c10b for some reason
(else I would have realized that this is the ordering used) - sorry
for the noise.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel