Re: [Xen-devel] [PATCH v3 07/13] xen/passthrough: iommu: Introduce arch specific code

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 03/18/2014 04:27 PM, Ian Campbell wrote:
> On Tue, 2014-03-11 at 15:49 +0000, Julien Grall wrote:
>> +struct arch_hvm_iommu
>> +{
>> +    u64 pgd_maddr;                 /* io page directory machine address */
>> +    int agaw;     /* adjusted guest address width, 0 is level 2 30-bit */
>> +    u64 iommu_bitmap;              /* bitmap of iommu(s) that the domain 
>> uses */
> 
> Blank line here for clarity?

Sure.

>> +    /* amd iommu support */
>> +    int paging_mode;
>> +    struct page_info *root_table;
>> +    struct guest_iommu *g_iommu;
>> +
> 
> I don't think the following are amd specific, in their original home
> they were up with pgd_maddr and co any way. If they are to stay here
> perhaps a new /* heading */ comment would help?

I don't remember why I changed the order. I will go back to original
order in the next version.

Regards,


-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel