Re: [Xen-devel] [PATCH] xen-access: Do not use ERROR out of xc handle scope

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-18 at 11:13 +0100, Tim Deegan wrote:
> Hi,
> 
> At 20:15 +0000 on 17 Mar (1395083738), Aravindh Puthiyaparambil (aravindp) 
> wrote:
> > In places where xc handle is not in scope, use standard printf to display 
> > errors.
> > 
> > Signed-off-by: Aravindh Puthiyaparambil <aravindp@xxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> 
> This is OK as far as it goes, but this code should not be using
> ERROR() &c at all -- those are libxc internals, and since we're not
> providing a logger argument or any flags to xc_interface_open, I don't
> think they do anything useful here.  How about something like this
> (compile-tested only):
> 
> ---8<----
> 
> tools/xen-access: don't use libxc internals directly.

Was the platform info stuff just completely unused?

> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel