Re: [Xen-devel] [PATCH 1/5] xentoollog: provide XTL_STDIOSTREAM_PROGRESS_USE_CR

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-03-17 at 16:03 +0000, Ian Jackson wrote:
> Provide flags
>   XTL_STDIOSTREAM_PROGRESS_USE_CR
>   XTL_STDIOSTREAM_PROGRESS_NO_CR
> to allow the caller to force, or disable, the use of \r-based
> overwriting of progress messages.
> 
> In the implementation, rename the variable "tty" to "progress_use_cr".
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Olaf Hering <olaf@xxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> ---
>  tools/libxc/xentoollog.h       |    8 +++++---
>  tools/libxc/xtl_logger_stdio.c |   18 +++++++++++++++---
>  2 files changed, 20 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/libxc/xentoollog.h b/tools/libxc/xentoollog.h
> index 6d36dd9..85d3da9 100644
> --- a/tools/libxc/xentoollog.h
> +++ b/tools/libxc/xentoollog.h
> @@ -65,9 +65,11 @@ struct xentoollog_logger {
>  
>  /*---------- facilities for consuming log messages ----------*/
>  
> -#define XTL_STDIOSTREAM_SHOW_PID      01u
> -#define XTL_STDIOSTREAM_SHOW_DATE     02u
> -#define XTL_STDIOSTREAM_HIDE_PROGRESS 04u
> +#define XTL_STDIOSTREAM_SHOW_PID            001u
> +#define XTL_STDIOSTREAM_SHOW_DATE           002u
> +#define XTL_STDIOSTREAM_HIDE_PROGRESS       004u
> +#define XTL_STDIOSTREAM_PROGRESS_USE_CR     010u /* default is to */
> +#define XTL_STDIOSTREAM_PROGRESS_NO_CR      020u /* use \r to ttys */

Not often you see an octal constant!

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel