[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v9 1/6] x86: detect and initialize Cache QoS Monitoring feature
>>> On 18.03.14 at 15:44, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:
>> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
>> There is a sensible upper bound for rmid_max, in the init function.
>> There should be a set of pointers (one per socket), allocated on use,
>> which can contain rmid_max data.
>>
>> Once allocated, they are large enough for any eventuality, and don't
>> need de/reallocating. This way, the amount of memory used is
>> sockets_inuse * rmid_max.
>
> Hmm, this might be a good proposal, since according to the SDM (figure
> 17-20), the possible maximum rmid value may be 2^10=1024.
> Therefore for each socket, 2 pages are enough. (1024 * 8 = 8192)
> But we may need to track such per-socket structure in CPU online/offline
> logic.
>
> Jan, what's your opinion?
Sounds reasonable if you can make it work cleanly.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
