Re: [Xen-devel] [PATCH 3/4] xen: arm: add barrier before sev in smp_spin_table_cpu_up

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 03/17/2014 02:39 PM, Ian Campbell wrote:
>>> The ARMv8 ARM recommends that sev() is usually accompanied by a dsb(), the
>>> only other uses are in the v7 spinlock code which includes a dsb() already.
>>
>> Would it be better to add dsb in the sev() macro?
> 
> ARM32 has a dsb_sev macro, maybe we should do the same for ARM64.

Do we really need to rename the macro? From what I understand, most of
the time sev => dsb before. I think we can hide it in sev() macro.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel