Re: [Xen-devel] [PATCH] xen/grant-table: Refactor gnttab_[un]map_refs to avoid m2p_override

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 10 Mar 2014, David Vrabel wrote:
> On 27/02/14 15:55, Zoltan Kiss wrote:
> > (This is a continuation of "[PATCH v9] xen/grant-table: Avoid m2p_override
> > during mapping")
> > 
> > The grant mapping API does m2p_override unnecessarily: only gntdev needs it,
> > for blkback and future netback patches it just cause a lock contention, as
> > those pages never go to userspace. Therefore this series does the following:
> > - the bulk of the original function (everything after the mapping hypercall)
> >   is moved to arch-dependent set/clear_foreign_p2m_mapping
> > - the "if (xen_feature(XENFEAT_auto_translated_physmap))" brach goes to ARM
> > - therefore the ARM function could be much smaller, the m2p_override stubs
> >   could be also removed
> > - on x86 the set_phys_to_machine calls were moved up to this new funcion
> >   from m2p_override functions
> > - and m2p_override functions are only called when there is a kmap_ops param
> > 
> > It also removes a stray space from arch/x86/include/asm/xen/page.h.
> 
> Applied to devel/for-linus-3.15.

The patch breaks the ARM build:

arch/arm/xen/p2m.c:152:1: error: expected identifier or '(' before '{' token
 {
 ^
arch/arm/xen/p2m.c:169:1: error: expected identifier or '(' before '{' token
 {
 ^


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel