Re: [Xen-devel] [RFC PATCH v2 2/3] arch, arm: add the XEN_DOMCTL_memory_mapping hypercall

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On gio, 2014-03-13 at 15:36 +0000, Jan Beulich wrote:
> >>> On 13.03.14 at 16:29, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> > "foo + foo_mfns" appears quite a lot here. I think you could calculate
> > those once into foo_start and foo_end and use throughout which would
> > make the remainder much easier to follow.
> > 
> > Oh, I see this came from the x86 function of which this is an almost
> > complete copy -- can it not be made common?
> > 
> > The difference seems to be map_mmio_regions vs. a loop over
> > set_mmio_p2m_entry which seems easy enough to abstract out.
> 
> Indeed.
> 
But, if I can ask, from where does this difference come from? If Arianna
is to make this common code, should she retain such difference or kill
it? I mean, do we want to keep having x86 mapping in loop and ARM
mapping all at once, or can we just merge that part two? If the former,
why?

ISTR, Arianna asked this already, but the answer was something like
"mapping all at once" is correct (someone correct me if I'm wrong).

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel