Re: [Xen-devel] [PATCH] xen: arm: increase priority of SGIs used as IPIs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 03/13/2014 12:45 PM, Ian Campbell wrote:
> On Thu, 2014-03-13 at 12:33 +0000, Julien Grall wrote:
>> Hi Ian,
>>
>> On 01/28/2014 04:51 PM, Ian Campbell wrote:
>>>      /* Set PPI and SGI priorities */
>>> -    for (i = 0; i < 32; i += 4)
>>> -        GICD[GICD_IPRIORITYR + i / 4] = 0xa0a0a0a0;
>>> +    for (i = 0; i < 16; i += 4)
>>> +        GICD[GICD_IPRIORITYR + i / 4] =
>>> +            GIC_PRI_IPI<<24 | GIC_PRI_IPI<<16 | GIC_PRI_IPI<<8 | 
>>> GIC_PRI_IPI;
>>> +    for (i = 16; i < 32; i += 4)
>>> +        GICD[GICD_IPRIORITYR + i / 4] =
>>> +            GIC_PRI_IRQ<<24 | GIC_PRI_IRQ<<16 | GIC_PRI_IRQ<<8 | 
>>> GIC_PRI_IRQ;
>>
>> I'm wondering if it's necessary to set the priority for PPIs. It will be
>> overridden later when the interrupt will be setup. Until that time, the
>> interrupt is not enabled.
> 
> Strictly speaking probably not, but there isn't much harm in setting a
> sane default I suppose.

Right, I didn't see that we also do that for SPIs.

I have a minor change to request, can you divide the comment "Set PPI
and SGI priorities" in 2 to reflect was does each loop?

Except that:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel