[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 0/5] xen/arm: Merge early_printk function in console code



>>> On 12.03.14 at 15:34, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> This patch series aims to merge early printk in the console code. This will
> avoid the developper to care whether the message is printed before or after
> the console is initialized.

Is ARM setting up the console so much later than x86 that this is
indeed warranted? IOW why can't you set up the console as early
as x86 does, and drop all uses of early_{printk,panic}?

Jan

> Julien Grall (5):
>   xen/arm: earlyprintk: move early_flush in early_puts
>   xen/arm: earlyprintk: export early_puts
>   xen/arm: Rename EARLY_PRINTK compile option to CONFIG_EARLY_PRINTK
>   xen/console: Add support for early printk
>   xen/arm: Replace early_{printk,panic} call to {printk,panic} call
> 
>  xen/arch/arm/Rules.mk              |    2 +-
>  xen/arch/arm/arm32/head.S          |   18 ++++-----
>  xen/arch/arm/arm64/head.S          |   18 ++++-----
>  xen/arch/arm/early_printk.c        |   36 +-----------------
>  xen/arch/arm/mm.c                  |    5 +--
>  xen/arch/arm/setup.c               |   28 +++++++-------
>  xen/common/device_tree.c           |   74 
> +++++++++++++++---------------------
>  xen/drivers/char/console.c         |    6 ++-
>  xen/drivers/char/dt-uart.c         |    9 ++---
>  xen/drivers/char/exynos4210-uart.c |   13 +++----
>  xen/drivers/char/omap-uart.c       |   13 +++----
>  xen/drivers/char/pl011.c           |   13 +++----
>  xen/drivers/video/arm_hdlcd.c      |   29 +++++++-------
>  xen/include/asm-arm/early_printk.h |   27 +------------
>  xen/include/xen/early_printk.h     |   21 ++++++++++
>  15 files changed, 130 insertions(+), 182 deletions(-)
>  create mode 100644 xen/include/xen/early_printk.h
> 
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.