Re: [Xen-devel] [PATCH 5/6] tools/libxl: Allow dom0 to be destroyed

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.03.14 at 23:51, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3059,11 +3059,6 @@ static void unpause_domain(uint32_t domid)
>  static void destroy_domain(uint32_t domid)
>  {
>      int rc;
> -

Don't remove the blank line here.

> -    if (domid == 0) {
> -        fprintf(stderr, "Cannot destroy privileged domain 0.\n\n");
> -        exit(-1);
> -    }

So this gets deleted without replacement? How is the hardware
domain being protected from (accidental or malicious) deletion
then? Even if this is being dealt with in the hypervisor, I'd be
afraid of the failure resulting in a cryptic error message instead
of the very clear one above.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel