Re: [Xen-devel] [PATCH v2 3/5] x86/time: Initialise time earlier during start_secondary()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.02.14 at 19:57, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/smpboot.c
> +++ b/xen/arch/x86/smpboot.c
> @@ -347,6 +347,8 @@ void start_secondary(void *unused)
>  
>      percpu_traps_init();
>  
> +    init_percpu_time();
> +
>      cpu_init();
>  
>      smp_callin();

I consider it rather risky to put this before the call to cpu_init().
While currently it doesn't seem like the function depends on any
of the CPU feature flags, I could easily see this to become
necessary.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel