Re: [Xen-devel] [PATCH] x86/hvm: assert that we we saved a sane number of MSRs.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.02.14 at 16:07, Tim Deegan <tim@xxxxxxx> wrote:
> Just as a backstop measure against later changes that add MSRs to the
> save function without updating the count in the init function.
> 
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
>  xen/arch/x86/hvm/hvm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 9e85c13..ae24211 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1148,6 +1148,8 @@ static int hvm_save_cpu_msrs(struct domain *d, 
> hvm_domain_context_t *h)
>          if ( hvm_funcs.save_msr )
>              hvm_funcs.save_msr(v, ctxt);
>  
> +        ASSERT(ctxt->count <= msr_count_max);
> +
>          for ( i = 0; i < ctxt->count; ++i )
>              ctxt->msr[i]._rsvd = 0;
>  
> -- 
> 1.8.5.2




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel