Re: [Xen-devel] [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends

[Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>]

On Wed, Feb 26, 2014 at 04:18:50PM +0100, Roger Pau Monné wrote:
> 
> I've realized I haven't Cc'ed the drbd developers lists, so adding it now.

We do read the user's list just as well.
Our -dev is actually mainly intended for "coordination".

> On 20/02/14 16:59, Roger Pau Monne wrote:
> > The type written to xenstore by libxl when attaching a drbd backend is
> > "phy", not "drbd", so handle this case also.

If you say so; you should know ;-)
Did this change at some point?
I personally have not used this script in a long while...

Do you ("citrix") have this in some
regression/integration testing yourself?

> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> >  scripts/block-drbd |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/block-drbd b/scripts/block-drbd
> > index 5563ccb..975802b 100755
> > --- a/scripts/block-drbd
> > +++ b/scripts/block-drbd
> > @@ -250,7 +250,7 @@ case "$command" in
> >      fi
> >  
> >      case $t in 
> > -      drbd)
> > +      drbd|phy)
> >          drbd_resource=$p
> >          drbd_role="$(drbdadm role $drbd_resource)"
> >          drbd_lrole="${drbd_role%%/*}"
> > @@ -278,7 +278,7 @@ case "$command" in
> >  
> >    remove)
> >      case $t in 
> > -      drbd)
> > +      drbd|phy)
> >          p=$(xenstore_read "$XENBUS_PATH/params")
> >          drbd_resource=$p
> >          drbd_role="$(drbdadm role $drbd_resource)"

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
__
please don't Cc me, but send to list   --   I'm subscribed

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel