[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V8 RESEND] ns16550: Add support for UART present in Broadcom TruManage capable NetXtreme chips

Aravind Gopalakrishnan wrote:
Since it is an MMIO device, the code has been modified to accept MMIO based
devices as well. MMIO device settings are populated in the 'uart_config' table.
It also advertises 64 bit BAR. Therefore, code is reworked to account for 64
bit BAR and 64 bit MMIO lengths.

Some more quirks are - the need to shift the register offset by a specific
value and we also need to verify (UART_LSR_THRE&&  UART_LSR_TEMT) bits before
transmitting data.

While testing, include com1=115200,8n1,pci,0 on the xen cmdline to observe
output on console using SoL.

Changes from V7:
   - per Jan's comments:
     - Moving pci_ro_device to ns16550_init_postirq() so that either
       one of pci_hide_device or pci_ro_device is done at one place
     - remove leading '0' from printk as absent segment identifier
       implies zero anyway.
   - per Ian's comments:
     - fixed issues that casued his build to fail.
     - cross-compiled for arm32 and arm64 after applying patch and
       build was successful on local machine.

Signed-off-by: Aravind Gopalakrishnan<Aravind.Gopalakrishnan@xxxxxxx>
Signed-off-by: Suravee Suthikulpanit<Suravee.Suthikulpanit@xxxxxxx>
Signed-off-by: Thomas Lendacky<Thomas.Lendacky@xxxxxxx>
Acked-by: Keir Fraser <keir@xxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.