[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH 4/8] x86/xen: only warn once if bad MFNs are found during setup



From: David Vrabel <david.vrabel@xxxxxxxxxx>

In xen_add_extra_mem(), if the WARN() checks for bad MFNs trigger it is
likely that they will trigger at lot, spamming the log.

Use WARN_ONCE() instead.

Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
---
 arch/x86/xen/setup.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index 0982233..2afe55e 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -89,10 +89,10 @@ static void __init xen_add_extra_mem(u64 start, u64 size)
        for (pfn = PFN_DOWN(start); pfn < xen_max_p2m_pfn; pfn++) {
                unsigned long mfn = pfn_to_mfn(pfn);
 
-               if (WARN(mfn == pfn, "Trying to over-write 1-1 mapping (pfn: 
%lx)\n", pfn))
+               if (WARN_ONCE(mfn == pfn, "Trying to over-write 1-1 mapping 
(pfn: %lx)\n", pfn))
                        continue;
-               WARN(mfn != INVALID_P2M_ENTRY, "Trying to remove %lx which has 
%lx mfn!\n",
-                       pfn, mfn);
+               WARN_ONCE(mfn != INVALID_P2M_ENTRY, "Trying to remove %lx which 
has %lx mfn!\n",
+                         pfn, mfn);
 
                __set_phys_to_machine(pfn, INVALID_P2M_ENTRY);
        }
-- 
1.7.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.