Re: [Xen-devel] [PATCH v3 4/5] xen: Misc cleanup as a result of the previous patches

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.02.14 at 16:01, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -875,7 +875,6 @@ static int sh_skip_sync(struct vcpu *v, mfn_t gl1mfn)
>      SHADOW_ERROR("gmfn %#lx was OOS but not shadowed as an l1.\n",
>                   mfn_x(gl1mfn));
>      BUG();
> -    return 0; /* BUG() is no longer __attribute__((noreturn)). */
>  }

Did you check that this is fine with the whole range of compiler
versions we support? Also, s/no longer/now/ ?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel