Re: [Xen-devel] [PATCH v9 2/6] x86: dynamically attach/detach CQM service for a guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.02.14 at 07:32, Dongxiao Xu <dongxiao.xu@xxxxxxxxx> wrote:
> @@ -1245,6 +1246,33 @@ long arch_do_domctl(
>      }
>      break;
>  
> +    case XEN_DOMCTL_attach_pqos:
> +    {
> +        if ( !(domctl->u.qos_type.flags & XEN_DOMCTL_pqos_cqm) )
> +            ret = -EINVAL;
> +        else if ( !system_supports_cqm() )
> +            ret = -ENODEV;
> +        else
> +            ret = alloc_cqm_rmid(d);
> +    }

Pointless curly braces.

> +    case XEN_DOMCTL_detach_pqos:
> +    {
> +        if ( !(domctl->u.qos_type.flags & XEN_DOMCTL_pqos_cqm) )
> +            ret = -EINVAL;
> +        else if ( !system_supports_cqm() )
> +            ret = -ENODEV;
> +        else if ( d->arch.pqos_cqm_rmid > 0 )
> +        {
> +            free_cqm_rmid(d);
> +            ret = 0;
> +        }
> +        else
> +            ret = -ENOENT;
> +    }

Again.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel