[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V4 net-next 2/5] xen-netback: Add support for multiple queues

On 21/02/14 12:22, David Vrabel wrote:
+    char *xspath = NULL;

I don't think you need the NULL init here. xspath is set in both
branches of the if statement below.

Indeed, but I prefer to initialise things sanely where possible. It
makes it easier to spot problems with later modifications of the code,
e.g. if one of those branches changed.

Kernel style (but probably not documented anywhere) is to only
initialize locals were necessary.


Ok, I'll remove the NULL initialiser then.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.