Re: [Xen-devel] [PATCH V4.1] mcheck, vmce: Allow vmce_amd_* functions to handle AMD thresolding MSRs

[Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>]

On 2/18/2014 6:42 AM, Liu, Jinsong wrote:
> Jan Beulich wrote:
> > > > > On 18.02.14 at 12:42, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> > > Jan Beulich wrote:
> > > > > > > On 18.02.14 at 11:52, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
> > > > > > > wrote:
> > > > > > > > --- a/xen/arch/x86/cpu/mcheck/vmce.c
> > > > > > > > +++ b/xen/arch/x86/cpu/mcheck/vmce.c
> > > > > > > > @@ -107,7 +107,8 @@ static int bank_mce_rdmsr(const struct vcpu
> > > > > > > > *v, uint32_t msr, uint64_t *val)
> > > > > > > >
> > > > > > > >       *val = 0;
> > > > > > > >
> > > > > > > > -    switch ( msr & (MSR_IA32_MC0_CTL | 3) )
> > > > > > > > +    /* Allow only first 3 MC banks into switch() */
> > > > > I don't think this comments is good here. Remove it is better.
> > > > I had asked for this to be removed again too. I'm really thinking
> > > > that V3 is what we should go with.
> > > V3 is fine, except adding comments for '-MSR_IA32_MC0_CTL' is
> > > slightly better.
> > Can I read this as an ack then (I already explained elsewhere
> > why I think a comment there is rather pointless)?
> >
> > Jan
Ok, guess V3 is good enough..

> Yes, please.
>
> Reviewed-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
Thanks,
-Aravind.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel