Re: [Xen-devel] missing dependency on libxlu_disk_l.h

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> On Sat, 2014-02-15 at 23:17 +0100, Olaf Hering wrote:
> > I'm not sure if libxlu_disk_l.h is a generated file.
> 
> It is, but we also check in the generated version, IIRC due to a bug in
> some versions of flex, but also partially for convenience to avoid the
> need for flex on all development systems.

Right.

> >  But just once I saw
> > this failure below with automated build and make -j 16. This source tree
> > has the discard-enable patch, which changes tools/libxl/libxlu_disk_l.l.
> > As a result libxlu_disk_l.c is regenerated, see the flex call below.
> 
> It might be a good idea to either also patch the generated files or to
> have the patch remove them, to avoid any possible confusion due to skew.

This ought to be taken care of by the build system, provided you don't
actually git commit only the change to .l and not the change to .[ch].
In the final patch.

> > How should make become aware of the libxlu_disk_l.h dependency?
> 
> I think it would probably need explicitly specifying like we do for the
> IDL generated files.

There is already a place to put this.  See diff below.  Sorry for not
doing this at the time.

> What deleted that file though?

make might have done.

Olaf, can you test whether this diff makes the problem go away for you ?

Thanks,
Ian.

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index dab2929..755b666 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
 $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include 
$(XEN_ROOT)/tools/config.h
 
 AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
-       _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+       libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
 AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
 AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
 LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel