[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTest] standalone-reset: actually honour '-f' option

Dario Faggioli writes ("Re: [Xen-devel] [OSSTest] standalone-reset: actually 
honour '-f' option"):
> On mer, 2014-01-29 at 14:32 +0000, Dario Faggioli wrote:
> > standalone-reset's usage says:
> >     
> >   usage: ./standalone-reset [<options>] [<branch> [<xenbranch> 
> > [<buildflight>]]]
> >    branch and xenbranch default, separately, to xen-unstable
> >   options:
> >    -f<flight>     generate flight "flight", default is "standalone"
> >     
> > but then there is no place where '-f' is processed, and hence
> > no real way to pass a specific flight name to make-flight.
> >     
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> I know it's a busy period for OSSTest, but this should be pretty
> straightforward, and it only affects standalone mode.

Right.  I don't use standalone mode much, so sorry about that.  I
looked for a comment from Ian C but didn't find one.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> Anyway, I can put it on hold and resubmit in a while, if that's
> considered better.

No, pinging now is good.

This patch leads me to an observation: I looked at the code in
standalone-reset and it appears to me that there is not currently
anything which sets "$flight".

So the "DELETE" statements used if there's an existing db won't have
any effect.  This doesn't cause any strange effects because
Osstest/JobDB/Standalone.pm deletes them too.

I think it would be best to delete that part of standalone-reset.  Do
you agree ?

In the meantime I have added your patch to my queue branch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.