Re: [Xen-devel] [PATCH V2 net-next 2/5] xen-netback: Add support for multiple queues

[Andrew Bennieston <andrew.bennieston@xxxxxxxxxx>]

On 14/02/14 15:36, Wei Liu wrote:
> On Fri, Feb 14, 2014 at 02:57:25PM +0000, Andrew Bennieston wrote:
> > On 14/02/14 14:11, Wei Liu wrote:
> > > On Fri, Feb 14, 2014 at 11:50:21AM +0000, Andrew J. Bennieston wrote:
> > > [...]
> > > > +extern unsigned int xenvif_max_queues;
> > > > +
> > > >   #endif /* __XEN_NETBACK__COMMON_H__ */
> > > > diff --git a/drivers/net/xen-netback/interface.c 
> > > > b/drivers/net/xen-netback/interface.c
> > > > index 4cde112..4dc092c 100644
> > > > --- a/drivers/net/xen-netback/interface.c
> > > > +++ b/drivers/net/xen-netback/interface.c
> > > > @@ -373,7 +373,12 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t 
> > > > domid,
> > > >         char name[IFNAMSIZ] = {};
> > > >
> > > >         snprintf(name, IFNAMSIZ - 1, "vif%u.%u", domid, handle);
> > > > -       dev = alloc_netdev_mq(sizeof(struct xenvif), name, ether_setup, 1);
> > > > +       /* Allocate a netdev with the max. supported number of queues.
> > > > +        * When the guest selects the desired number, it will be updated
> > > > +        * via netif_set_real_num_tx_queues().
> > > > +        */
> > > > +       dev = alloc_netdev_mq(sizeof(struct xenvif), name, ether_setup,
> > > > +                                                 xenvif_max_queues);
> > > Indentation.
> > How would you like this to be indented? The CodingStyle says (and I quote):
> > Chapter 2: Breaking long lines and strings:
> >         ... descendants are always substantially shorter than the
> >         parent and placed substantially to the right...
> >
> > There is no further advice to this point in CodingStyle, so please
> > explain how you'd prefer this.
> Kernel code in general use indentation style like
>
>         dev = alloc_netdev_mq(sizeof(struct xenvif), name, ether_setup,
>                               xenvif_max_queues);
>
> You can find lots of examples in existing kernel code.
>
> Probably "place substantially to the right" is just too vague. :-)
Ah, I think the issue here is that my editor was configured to have a 
tab width of 4, so the offending line _did_ look to be aligned to the 
opening ( of the line above, to me. I'll set the appropriate tab width 
and change it.
Cheers,
Andrew
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel