Re: [Xen-devel] [PATCH RFC 12/13] mca: disable cmc enable on Xen PV

[John Baldwin <jhb@xxxxxxxxxxx>]

On Tuesday, December 24, 2013 12:21:01 PM Roger Pau Monne wrote:
> Xen PV guests doesn't have a lapic, so disable the lapic call in mca
> initialization.

I think this is fine, but I wonder if it wouldn't be cleaner to have 
lapic_enable_cmc() do the check instead.  Where else do you check 
lapic_disabled?

> ---
>  sys/x86/x86/mca.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sys/x86/x86/mca.c b/sys/x86/x86/mca.c
> index f1369cd..e9d2c1d 100644
> --- a/sys/x86/x86/mca.c
> +++ b/sys/x86/x86/mca.c
> @@ -897,7 +897,7 @@ _mca_init(int boot)
>               }
> 
>  #ifdef DEV_APIC
> -             if (PCPU_GET(cmci_mask) != 0 && boot)
> +             if (PCPU_GET(cmci_mask) != 0 && boot && !lapic_disabled)
>                       lapic_enable_cmc();
>  #endif
>       }

-- 
John Baldwin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel