[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/xc: pass errno to callers of xc_domain_save

On Mon, Feb 10, Olaf Hering wrote:

> Now libxl_save_helper:complete can print the actual error string. Also
> checkpoint is updated to pass the errno to its caller.

> @@ -209,9 +209,11 @@ int checkpoint_start(checkpoint_state* s, int fd,
>      rc = xc_domain_save(s->xch, fd, s->domid, 0, 0, flags, callbacks, hvm,
>                          vm_generationid_addr);
> +    errnoval = errno;
>      if (hvm)
>         switch_qemu_logdirty(s, 0);
> +    errno = errnoval;
>      return rc;

It just occoured to me that this part is wrong:
rc should have been 'rc ? -1 : 0;'. And in addition to that the caller
pycheckpoint_start expects checkpoint_state->errstr should be set to
some error string. So this part of the patch has to be dropped.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.