[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] Domain Save Image Format proposal (draft B)
On Mon, Feb 10, 2014 at 9:20 AM, David Vrabel <david.vrabel@xxxxxxxxxx> wrote: Here is a draft of a proposal for a new domain save image format. It I suggest keeping the processing overhead in mind when designing the new image format. Some key things have been addressed, such as making sure data
is always padded to maintain alignment. But there are also some aspects of this proposal that seem awfully unnecessary.. More details below.
So far so good. Integer (numeric) fields in the image header are always in big-endian Its tempting to adopt all the TCP-style madness for transferring a set of structured data. Why this endian-ness mess? Am I missing something here?
I am assuming that a lion's share of Xen's deployment is on x86 (not including Amazon). So that leaves ARM. Why not let these processors take the hit of endian-ness conversion? Headers and more endian-ness mess.
I am assuming that you the checksum field is present only for debugging purposes? Otherwise, I see no reason for the computational overhead, given that we are already sending data
over a reliable channel + IIRC we already have an image-wide checksum when saving the image to disk. If debugging is the only use case, then I guess, the type field can be prefixed with a 1/0 bit, eliminating the need for the
1-bit checkum options field + 7-byte padding. Similarly, if debugging mode is not set, why waste another 8 bytes in the end for the checksum field. Unless you think there may be more types with need of special options,
Feel free to correct me if I am missing something elementary here.. -------------------------------------------------------------------- The following sub-sections specify the record body format for each of s/uncompressed/(compressed/uncompressed)/ (Remus sends compressed data) VCPU_INFO 6. VCPU_INFO record 7. END record There seems to be a bunch of info missing. Here are some missing elements that I can recall at the moment: a) there is no support for sending over one time markers that switch the
receiver's operating mode in the middle of a data stream. E.g., XC_SAVE_ENABLE_COMPRESSION, XC_SAVE_ID_LAST_CHECKPOINT, etc. XC_SAVE_ENABLE_VERIFY_MODE, b) in pv case, the tail also has a list of unmapped PFNs at the end of every iteration.
c) XC_SAVE_ID_TOOLSTACK -- used by xl to pass device context information (generally for HVMs).
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |