Re: [Xen-devel] [PATCH OSSTEST] icr-daily-branch: Make it possible to suppress the forcing of a baseline test

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-02-10 at 12:01 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] icr-daily-branch: Make it possible to 
> suppress the forcing of a baseline test"):
> > This is undesirable (most of the time) in a standalone environment, where 
> > you
> > are mostl ikely to be interested in the current version and not historical
> > comparissons.
> > 
> > Not sure there isn't a better way.
> 
> I think this is fine, although it still runs sg-check-tested
> unnecessarily.
> 
> > -if [ "x$testedflight" = x ]; then
> > +if [ "${OSSTEST_NO_BASELINE:-n}" != "y" -a "x$testedflight" = x ]; then
> 
> I do have a stylistic quibble: this seems quite fiddly syntzx and not
> the way that things are done elsewhere.  I would suggest doing it like
> OSSTEST_IGNORE_STOP in cri-args-hostlists:
> 
> > +if [ "x$OSSTEST_NO_BASELINE" != xy -a "x$testedflight" = x ]; then
> 
> or similar earlier if you want to make check_tested conditional.
> 
> The thing with the x prefix is to make it clear that the arguments are
> being unparsed correctly (ie that [ is going to parse its arguments
> how we hope it to).  Without something like the "x" trick there are
> some cases where it is very complicated to reason about ['s argument
> parsing, and it is IMO simpler to always deploy the x than to prove in
> each case that the parsing is predictable.

Ack. I'll make a change along those lines, and have a look at
check_tested too.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel