Re: [Xen-devel] [RFC for-4.5 03/12] xen/passthrough: vtd: Don't export iommu_set_pgd

["Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>]

Acked-by: Xiantao Zhang <Xiantao.zhang@xxxxxxxxx>
Xiantao
-----Original Message-----
From: Jan Beulich [mailto:JBeulich@xxxxxxxx] 
Sent: Monday, February 10, 2014 4:05 PM
To: Julien Grall
Cc: ian.campbell@xxxxxxxxxx; stefano.stabellini@xxxxxxxxxx; Zhang, Xiantao; 
patches@xxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx; tim@xxxxxxx
Subject: Re: [RFC for-4.5 03/12] xen/passthrough: vtd: Don't export 
iommu_set_pgd

>>> On 07.02.14 at 18:43, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> iommu_set_pgd is only used internally in 
> xen/drivers/passthrough/vtd/iommu.c
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: Xiantoa Zhang <xiantao.zhang@xxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
>  xen/drivers/passthrough/vtd/iommu.c |    2 +-
>  xen/include/xen/iommu.h             |    1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/vtd/iommu.c
> b/xen/drivers/passthrough/vtd/iommu.c
> index a8d33fc..d5ce5b7 100644
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -1826,7 +1826,7 @@ static int vtd_ept_page_compatible(struct iommu 
> *iommu)
>  /*
>   * set VT-d page table directory to EPT table if allowed
>   */
> -void iommu_set_pgd(struct domain *d)
> +static void iommu_set_pgd(struct domain *d)
>  {
>      struct hvm_iommu *hd  = domain_hvm_iommu(d);
>      mfn_t pgd_mfn;
> diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 
> 8bb0a1d..fcbc432 100644
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -68,7 +68,6 @@ int iommu_map_page(struct domain *d, unsigned long 
> gfn, unsigned long mfn,
>                     unsigned int flags);  int iommu_unmap_page(struct 
> domain *d, unsigned long gfn);  void iommu_pte_flush(struct domain *d, 
> u64 gfn, u64 *pte, int order, int present); -void iommu_set_pgd(struct 
> domain *d);  void iommu_domain_teardown(struct domain *d);
>  
>  void pt_pci_init(void);
> --
> 1.7.10.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel