Re: [Xen-devel] [PATCH 02/13 V6] remus: implement network buffering hotplug scripts

[Lai Jiangshan <laijs@xxxxxxxxxxxxxx>]

On 01/28/2014 05:29 PM, Ian Campbell wrote:
> On Mon, 2014-01-27 at 10:05 -0800, Shriram Rajagopalan wrote:
>> On Sun, Jan 26, 2014 at 11:06 PM, Wen Congyang <wency@xxxxxxxxxxxxxx>
>> wrote:
>>         > The last time I posted this script, the feedback was that
>>         the script and> the code invoking > the script should be in a
>>         single patch. So I would suggest doing the same.
>>         
>>         
>>         We use the script in patch6. It adds 479 lines. These two
>>         patches are big patches(add more than 100 lines), so why put
>>         them into a single patch?
> 
>>
>> That is a valid question. IIRC, IanJ was the one who wanted the code
>> and the script together. IanJ, any thoughts?

> 
> Unless the patches are so big they won't get past the mailing list
> filters (which are 100s of Kb I think) the important thing is the
> logical separation of functionality into separate patches, not the
> individual line count of each patch.
> 

We did the logically separate, patches are split by functionalities, ^_^.
They are a little more fine-grain-separation than previous versions.
fine-grain-separation patches are much convenient to be reviewed in the
mail-list and in the future changlog.

If any one insist the original way, we will change it back.

thx,
Lai

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel