Re: [Xen-devel] [BUG]Cannot build mini-os-x86_64-c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-02-07 at 01:34 +0100, Samuel Thibault wrote:
> Ian Campbell, le Mon 03 Feb 2014 10:28:07 +0000, a Ãcrit :
> > On Sat, 2014-02-01 at 17:55 +0900, Masaki Muranaka wrote:
> > > I got the build error. Log is like this:
> > > /home/azureuser/xen/stubdom/mini-os-x86_64-c/test.o: In function
> > > `app_main':
> > > 
> > > /home/azureuser/xen/extras/mini-os/test.c:542: multiple definition of
> > > `app_main'
> > > /home/azureuser/xen/stubdom/mini-os-x86_64-c/main.o:/home/azureuser/xen/extras/mini-os/main.c:187:
> > >  first defined here
> > > make[1]: *** [/home/azureuser/xen/stubdom/mini-os-x86_64-c/mini-os]
> > > Error 1
> > > make[1]: Leaving directory `/home/azureuser/xen/extras/mini-os'
> > > make: *** [c-stubdom] Error 2
> > > 
> > > 
> > > 
> > > 
> > > I thinks stubdom/c/minios.cfg should be like this.
> > 
> > That sounds plausible. I'm not sure what would then include the tests at
> > that point though.
> 
> IIRC, by building mini-os by itself (without any stubdom part, i.e. no
> libc)

I thought that but I wasn't able to confirm by inspection of the
Makefile etc. It's not a big deal IMHO, if someone cares they will fix
it...

> > If Samuel agrees with the patch
> 
> Yes.  I wonder how that didn't pose problem so far.

I don't think we build the c stubdom by default -- maybe for this
reason.

Masaki, if you submit a patch you could also consider adding this to the
default set of stubdoms to build (or not, up to you).

Ian.

> 
> > please could you formally submit according to
> > http://wiki.xen.org/wiki/Submitting_Xen_Patches
> 
> Samuel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel