[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build.

On 06/02/14 15:04, Ian Campbell wrote:
On Thu, 2014-02-06 at 14:48 +0000, Julien Grall wrote:

On 05/02/14 16:03, Ian Campbell wrote:
     > +void sync_page_to_ram(unsigned long mfn)
+    void *v = map_domain_page(mfn);
+    flush_xen_dcache_va_range(v, PAGE_SIZE);

flush_xen_dcache_va_range uses DCCMVAC (for ARM32 bits), which only
clean the cache.

Following your commit message, we might want to use DCCIMVAC.

Yes, I think you are right, I thought this function invalidated as well.

I was wondering if we can change the behaviour of flush_xen_dcache_va_range. Invalidate the cache should not harm the other call-site.

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.